feat!(catalog-managed): New copy_atomic StorageHandler method #1400
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1400 +/- ##
==========================================
- Coverage 84.80% 84.79% -0.01%
==========================================
Files 118 118
Lines 30325 30366 +41
Branches 30325 30366 +41
==========================================
+ Hits 25716 25748 +32
- Misses 3382 3387 +5
- Partials 1227 1231 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
zachschuermann
changed the title
zachschuermann
force-pushed
the
engine-copy
branch
from
23477de to
cd0a59a
Compare
nicklan
reviewed
Oct 21, 2025
zachschuermann
changed the title
DrakeLin
reviewed
Oct 22, 2025
| // Read source file then write atomically with PutMode::Create | ||
| // This ensures: 1) atomicity 2) fails if destination exists | ||
| self.task_executor.block_on(async move { | ||
| let data = store.get(&src_path).await?.bytes().await?; |
There was a problem hiding this comment.
Are there concerns about the size of the data we're loading into memory?
There was a problem hiding this comment.
yes but i'm advocating not to optimize here. i'll open a follow up to track this tho
zachschuermann
force-pushed
the
engine-copy
branch
from
b0671cc to
a24e6b7
Compare
nicklan
approved these changes
Oct 22, 2025
DrakeLin
approved these changes
Oct 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
Adds a new required method:
copy_atomic(&self, src: &Url, dest: &Url) -> DeltaResult<()>toStorageHandler. This PR also adds support for the default engine via the (dumb) way of GET/PUT. Note that I've elected to pursue the simple/correct thing here and we can attempt to optimize in the future (and can open a follow-up if others agree).This implementation proposes a slight departure from existingEngineAPIs: instead of returning aDeltaResult<()>we returnResult<(), CopyError>with CopyError defined as:old pieces on CopyError omitted
It captures the only things we care about from the
copyAPI perspective: either the destination already exists and we can return a nice error message to the user saying their commit has already been published (considering publishing is the main use case of this API for now) or we just got back some other random error which we don't really care what it is, but rather just something we can surface to the user and fail the overall publish API.I've used this PR as an opportunity to introduce an Engine API more aligned with our pursuit of finer-grainer errors (especially for Engine trait) but happy to split out if we think it's better to just retain existing
DeltaResultpattern.Motivation
This PR will be used for commit publishing - basically copying commits from staged commits to published commits. See #1377 for some context on future usage.
This PR affects the following public APIs
New required method in
StorageHandlertrait:copy_atomicHow was this change tested?
new UT for default engine impl